fix(s3): ignore prefixes with repeating delimiters#59597
Merged
leftybournes merged 1 commit intomasterfrom Apr 22, 2026
Merged
Conversation
leftybournes
added
bug
3. to review
leftybournes
requested review from
ArtificialOwl,
artonge,
icewind1991 and
salmart-dev
and removed request for
a team
Contributor
|
please backport to 31 also |
CarlSchwan
approved these changes
Apr 14, 2026
artonge
reviewed
Apr 14, 2026
| // sub folders | ||
| if (is_array($result['CommonPrefixes'])) { | ||
| foreach ($result['CommonPrefixes'] as $prefix) { | ||
| if (preg_match('/\/{2,}$/', $prefix['Prefix'])) { |
Collaborator
There was a problem hiding this comment.
I trust that it works, but I don't get it.
- Where are those repeated
/coming from? From the NC config or from Amazon? - Do I understand it correctly that this is ignoring repeated
/coming from Amazon response?
Member
Author
There was a problem hiding this comment.
- It's coming from Amazon.
- Yes, that's right. It's ignoring it but anything after it is also ignored as a result.
Signed-off-by: Kent Delante <kent@delante.me> Amazon's hosted S3 service allows repeating delimiters in keys (e.g. 'path/to//file.txt' or 'path/to///file.txt') and we get repeating directories in the filecache as a result (based on the previous examples we get 'path/to/to/file.txt' or 'path/to/to/to/file.txt'). This ignores it and its contents for S3 external storage.
leftybournes
force-pushed
the
fix/s3_repeating_delimiter
branch
from
a2be017 to
6ce657f
Compare
leftybournes
changed the title
artonge
added
the
pending documentation
artonge
approved these changes
Apr 22, 2026
Collaborator
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
We need to document that path containing // will be ignored to prevent conflicts, else all good.
Member
Author
|
Documentation added here: nextcloud/documentation#14499 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Amazon's hosted S3 service allows repeating delimiters in keys (e.g. 'path/to//file.txt' or 'path/to///file.txt') and we get repeating directories in the filecache as a result (based on the previous examples we get 'path/to/to/file.txt' or 'path/to/to/to/file.txt'). This ignores it and its contents for S3 external storage.
Checklist
3. to review, feature component)stable32)AI (if applicable)