fix: Add missing PasswordConfirmationRequired attributes#59764
Merged
provokateurin merged 5 commits intomasterfrom Apr 21, 2026
Merged
fix: Add missing PasswordConfirmationRequired attributes#59764provokateurin merged 5 commits intomasterfrom
provokateurin merged 5 commits intomasterfrom
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ctions Register axios password confirmation interceptors in the apps management, admin delegation, admin security, and OAuth2 settings bundles, and pass PwdConfirmationMode.Strict on requests to endpoints protected with #[PasswordConfirmationRequired(strict: true)], so that the user password is verified via Basic auth on the request itself rather than relying on the session timestamp. Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
come-nc
requested review from
CarlSchwan,
leftybournes,
nfebe,
sorbaugh and
szaimen
and removed request for
a team
Contributor
Author
|
/compile / |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
provokateurin
approved these changes
Apr 21, 2026
Contributor
Author
|
Cypress failure is related |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App enabling should require a strict password confirmation.
Checklist
3. to review, feature component)stable32)AI (if applicable)