Fix sharer name overlap with filename#6506
Merged
MorrisJobke merged 2 commits intomasterfrom Sep 15, 2017
Merged
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
3. to review
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
force-pushed
the
sharename-overlap
branch
from
c54e367 to
42ac9cd
Compare
Member
|
Still a bit confusing But hey, that's a fix. |
skjnldsv
approved these changes
Sep 14, 2017
Member
Author
|
@skjnldsv yup – the right sidebar is an overlapping element in that sense though. I didn’t change anything there, but we could do things like make the filelist even narrower. Otherwise at some point we have to overlap anyway. :) |
Member
|
@jancborchardt we could hide stuff like I did on the mobile view, try changing the width of the window without the sidebar opened. This is true responsiveness 😃 |
MorrisJobke
approved these changes
Sep 15, 2017
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Better than nothing, but still a bit confusing. Sadly until we properly fixed the table there is not much we can do here. 👍
MorrisJobke
added
4. to release
Member
|
Waiting for CI: https://drone.nextcloud.com/nextcloud/server/1536 |
Member
|
Backport is in #6524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6498, please review @MorrisJobke @skjnldsv @nextcloud/designers
