Conversation
nathangibson14
left a comment
nathangibson14
left a comment
There was a problem hiding this comment.
Just a few pedantic comments.
| * | ||
| * The ContinuumEnergyAngle class is used to represent the continuum | ||
| * energy-angle law=1 data of MF26. It is similar to the MF6 law=1, but only | ||
| * supports the LANG=1 option (Legendre coefficients). |
There was a problem hiding this comment.
Pedantic comment... NA=0, so there are no coefficients 😄
| * | ||
| * The ContinuumEnergyAngle class is used to represent the two-body angular | ||
| * distribution law=2 data of MF26. It is similar to the MF6 law=1, but only | ||
| * supports the LANG=1 option (Legendre coefficients). |
There was a problem hiding this comment.
This documentation is messed up. Looks like a copy and paste from ContinuumEnergyAngle.
| std::move( boundaries ), | ||
| std::move( interpolants ), | ||
| std::move( energies ), | ||
| std::move( multiplicities ) ) {} |
There was a problem hiding this comment.
The ENDF manual says that the multiplicities must always be 1, not just "normally one". Thus, it doesn't really make sense to require it as an input. I think the only value of this constructor would be to make a user specify the energy range and the law.
That said, maybe consistency with MF6 is desired? So maybe this is okay?
| return | ||
| " 1.100000+1 5.438673-4 0 2 2 2 10026525 \n" | ||
| " 2 2 10026525 \n" | ||
| " 1.000000+1 1.000000+0 1.00000+11 1.000000+0 10026525 \n"; |
There was a problem hiding this comment.
If we're going to leave multiplicity as a user input, we should have a checkMultiplicity function that makes sure it's all 1s.
| @@ -0,0 +1,42 @@ | |||
| /** | |||
There was a problem hiding this comment.
Missing the Python default constructor.
There was a problem hiding this comment.
The python bindings compile so it might not be required. I'll still add it to be safe.
| std::string buffer; | ||
| auto output = std::back_inserter( buffer ); | ||
| chunk.print( output, 9228, 6, 5 ); | ||
| chunk.print( output, 9228, 26, 5 ); |
There was a problem hiding this comment.
You changed all the 6s to 26s. I don't think you meant to do this.
2 participants
And ... I'm done! Full MF26 capability ;-)