nit: update statement about OpenSSL and Node.js 10.x#1007
Closed
brody2consult wants to merge 2 commits intonodejs:mainfrom
Closed
nit: update statement about OpenSSL and Node.js 10.x#1007brody2consult wants to merge 2 commits intonodejs:mainfrom
brody2consult wants to merge 2 commits intonodejs:mainfrom
Conversation
brody2consult
commented
Mar 31, 2021
brody2consult
changed the title
Trott
approved these changes
Apr 1, 2021
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with or without semicolon and with or without "but".
Co-authored-by: Rich Trott <rtrott@gmail.com>
danbev
pushed a commit
that referenced
this pull request
Apr 8, 2021
PR-URL: #1007 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Co-authored-by: Rich Trott <rtrott@gmail.com>
Contributor
|
Landed in 5a5963a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.