fix(node): do not trust committed date#758
Merged
aduh95 merged 1 commit intonodejs:mainfrom Dec 8, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
+ Coverage 82.93% 82.97% +0.03%
==========================================
Files 37 37
Lines 4191 4200 +9
==========================================
+ Hits 3476 3485 +9
Misses 715 715 ☔ View full report in Codecov by Sentry. |
The date of a commit is provided by the user, and we should not trust it blindly. Instead, we can check when was the last push event to the PR base branch.
aduh95
force-pushed
the
commit-date-push-event
branch
from
4c261f2 to
2968f30
Compare
targos
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The date of a commit is provided by the user, and we should not trust it blindly. Instead, we can check when was the last push event to the PR base branch.