-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
Add vcbuild cpplint and and update CONTRIBUTING.md #11816
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Implement
cpplintforvcbuild.bat(i.e. a windows version of the equivalent Makefile target). Thenlintcan be implemented asjslintandcpplint.See #11151 (comment).
The line in #11151 can then be updated to reflect this addition (i.e. suggest that people use
vcbuild lint).Optimistically marking this as a
good first contributionas it should be a self-contained bit of Windows syntax to runtools/cpplint.pyandtools/check-imports.py.If you'd like to have a go at this then please comment here to let other people know. You can follow the guide in
CONTRIBUTING.mdto submit a PR.