5.x v8 debugger has broken 'restartframe' command

[3y3]

Is is broken in this line https://github.com/nodejs/node/blob/master/deps/v8/src/debug/debug.js#L2417

There is no RestartFrame func

[bnoordhuis]

Can you report that here? I expect that the fix looks like this:

diff --git a/deps/v8/src/debug/debug.js b/deps/v8/src/debug/debug.js
index 50bd0a9..493527a 100644
--- a/deps/v8/src/debug/debug.js
+++ b/deps/v8/src/debug/debug.js
@@ -2414,7 +2414,7 @@ DebugCommandProcessor.prototype.restartFrameRequest_ = function(
     frame_mirror = this.exec_state_.frame();
   }

-  var result_description = Debug.LiveEdit.RestartFrame(frame_mirror);
+  var result_description = frame_mirror.restart();
   response.body = {result: result_description};
 };

We can cherry-pick it once it lands upstream.

See here you want to work on it yourself. If you run into difficulties, let me know and I'll walk you through the process.

[matthewwithanm]

@bnoordhuis Can this be cherry-picked now? Fix here.

[MylesBorins]

I'll give it a go

[MylesBorins]

@matthewloring this landed in 937ac37

[matthewloring]

Redirecting mention to @matthewwithanm

[MylesBorins]

whoops.. that's what I get for going on autopilot

[matthewloring]

No worries 😄