Skip to content

full links to ROADMAP.md and link to docker-node#6253

Closed
williamkapke wants to merge 2 commits intomasterfrom
unknown repository
Closed

full links to ROADMAP.md and link to docker-node#6253
williamkapke wants to merge 2 commits intomasterfrom
unknown repository

Conversation

@williamkapke
Copy link
Copy Markdown
Contributor

@williamkapke williamkapke commented Apr 18, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Description of change

This synchronizes the changes I made on the website in nodejs/nodejs.org#660 to the WORKING_GROUPS.md.

  • The links to the roadmap were changed to the full URL so when the markdown is copied, they still resolve to the correct place.
  • The Docker Working Group's link now points to docker-node instead of docker-iojs.

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Apr 18, 2016
phillipj
phillipj reviewed Apr 18, 2016
View reviewed changes
Comment thread WORKING_GROUPS.md Outdated
Copy link
Copy Markdown
Member

@phillipj phillipj Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to be nodejs/node in these URLs, not noduh/node.

Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should TC be updated to CTC or TSC (I'm not sure who actually owns it).

Copy link
Copy Markdown
Member

@jasnell jasnell Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CTC

@evanlucas
Copy link
Copy Markdown
Contributor

evanlucas commented Apr 18, 2016

Thanks for the contribution! Can you please format the commit message as it is stated in https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit?

LGTM with the commit message updated and @phillipj's comment addressed

@cjihrig
Copy link
Copy Markdown
Contributor

cjihrig commented Apr 18, 2016

LGTM, same comment about the typos.

@Fishrock123
Copy link
Copy Markdown
Contributor

Fishrock123 commented Apr 19, 2016

What's the value in this?

Aside: the roadmap is probably quite out of date

@jasnell
Copy link
Copy Markdown
Member

jasnell commented Apr 20, 2016

ping @williamkapke ... few nits that need addressed in this

@estliberitas estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23
@Starefossen
Copy link
Copy Markdown
Member

Starefossen commented May 10, 2016

LGTM for the Docker link

@williamkapke
Copy link
Copy Markdown
Contributor Author

williamkapke commented Jun 20, 2016

This got really buried on my end- sry. @jasnell - those were more then just nits, those were absolute mess-ups on my part! ;)

@rvagg rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:01
@williamkapke
Copy link
Copy Markdown
Contributor Author

williamkapke commented Jan 2, 2017

the Roadmap WG was removed and now this PR is pointless 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@williamkapke @evanlucas @cjihrig @Fishrock123 @jasnell @Starefossen @phillipj @mscdex @nodejs-github-bot