wasi: accept int32 values for uint32 args#62822
Open
islandryu wants to merge 1 commit intonodejs:mainfrom
Open
wasi: accept int32 values for uint32 args#62822islandryu wants to merge 1 commit intonodejs:mainfrom
islandryu wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
islandryu
force-pushed
the
wasi-uint32-coercion
branch
from
8719763 to
9099d80
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62822 +/- ##
==========================================
+ Coverage 89.64% 89.68% +0.03%
==========================================
Files 676 706 +30
Lines 206240 218228 +11988
Branches 39514 41771 +2257
==========================================
+ Hits 184891 195707 +10816
- Misses 13465 14415 +950
- Partials 7884 8106 +222
🚀 New features to boost your workflow:
|
anonrig
reviewed
Apr 19, 2026
| @@ -306,6 +307,16 @@ uint32_t ConvertType(Local<Value> value) { | |||
| return value.As<Uint32>()->Value(); | |||
| } | |||
|
|
|||
| template <> | |||
Member
There was a problem hiding this comment.
Why do you need a template argument and a function for this one liner?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #62671
clock_time_get()receives time_ptr as a Wasm i32, which may appear as Int32 in JS.This PR accepts it as
int32_t, reinterprets it asuint32_t, and adds regression tests.