stream: reject duplicate nested transferables#62831
Open
daeyeon wants to merge 1 commit intonodejs:mainfrom
Open
stream: reject duplicate nested transferables#62831daeyeon wants to merge 1 commit intonodejs:mainfrom
daeyeon wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
panva
reviewed
Apr 19, 2026
Member
panva
left a comment
There was a problem hiding this comment.
LGTM; Can you also cover the change with our own test suite (independent of WPTs)?
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
Member
Author
|
@panva Added a separate test for this. PTAL. |
panva
approved these changes
Apr 19, 2026
Collaborator
jazelly
approved these changes
Apr 19, 2026
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62831 +/- ##
==========================================
- Coverage 89.69% 89.67% -0.02%
==========================================
Files 706 706
Lines 218270 218225 -45
Branches 41777 41774 -3
==========================================
- Hits 195774 195694 -80
- Misses 14404 14428 +24
- Partials 8092 8103 +11
π New features to boost your workflow:
|
MattiasBuelens
approved these changes
Apr 19, 2026
Contributor
MattiasBuelens
left a comment
There was a problem hiding this comment.
LGTM.
I could never figure out why that one WPT test was failing. Thanks for finding this!
Member
|
@daeyeon Thank you! I'll do a streams WPT update after this lands and from a cursory look there are a few new failures if you wanted to a look at those then too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
structuredClone()transfer-list validation for nested transfer conflicts.We already reject direct duplicate transfer entries, but validation could depend on
transfer-list order when transferring a
TransformStreamtogether with one of its members.This could be handled in two ways:
Nested transferables are currently expanded during validation, so this patch uses option 1.
Option 2 would require broader changes to the current transfer design than this fix warrants.