Skip to content

add LTS to releases table#300

Merged
stevemao merged 1 commit intomasterfrom
lts-in-releases-table
Oct 30, 2015
Merged

add LTS to releases table#300
stevemao merged 1 commit intomasterfrom
lts-in-releases-table

Conversation

@rvagg
Copy link
Copy Markdown
Member

@rvagg rvagg commented Oct 30, 2015

No description provided.

Comment thread scripts/load-versions.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Handlebars.js can ignore false values so no need to delete false property

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I added this exactly because it didn't ignore it and I ended up with a bunch of falses in the column

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvagg how do you like the {{#if lts}}{{lts}}{{/if}} solution I suggested below?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, missed it, have updated to use that instead, tbh I didn't know that was possible although I did a quick google for such syntax!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok :) not saying this is better though.

@rvagg rvagg force-pushed the lts-in-releases-table branch 2 times, most recently from bc95594 to 7736f29 Compare October 30, 2015 10:22
@stevemao
Copy link
Copy Markdown
Contributor

lts fields are deleted. @rvagg can you rerun npm run load-versions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants