Add back semicolons to the HTTP server example in about page#656
Merged
fhemberger merged 1 commit intomasterfrom Apr 18, 2016
Merged
Add back semicolons to the HTTP server example in about page#656fhemberger merged 1 commit intomasterfrom
fhemberger merged 1 commit intomasterfrom
Conversation
Contributor
|
Feel free to re-add the semicolons but the rest is actually better practice, I.e. Not using |
Member
Author
|
Forgive my ignorance but what's wrong with |
Contributor
|
Nothing is wrong with it, but chances are you are not going to be calling it directly from user code. :) |
1192126 to
2d664b2
Compare
Member
Author
|
I'm still not sure why I should prefer res.statusCode = 200;
res.setHeader('Content-Type', 'text/plain');over res.writeHead(200, { 'Content-Type': 'text/plain' });but it doesn't matter. I've updated the pr to only re-add the semicolons. |
Contributor
|
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #641
Not sure what are the better practices there, I guess the purpose was to test the bot.
Anyway I'm filing this pr because semicolons have been removed and this makes the example inconsistent with all the others (guides, API docs, etc).
cc: @Fishrock123