fetch

[ronag]

Refs: nodejs/undici#1203
Refs: #9

[anonrig]

I believe we should be much more descriptive about what we want to talk about, and add a Github issue template.

My ideal performance issue would be:

• Add a benchmark
• Mention the specific use case (hot path) for this performance issue
• Provide solutions (if available)

[metcoder95]

This is mostly referring to the WHATWG streams or there is something more underneath?

[mcollina]

I don't think this is done. I haven't seen any evidence of it, I still see a significant gap compared to http.request.

[mcollina]

Here is the latest data I have collected on Node.js v19.14.0:

$ CONNECTIONS=10 PIPELINING=10 PORT=3000 PARALLEL=100 SAMPLES=1000 node benchmarks/benchmark.js
│ Tests               │ Samples │          Result │ Tolerance │ Difference with slowest │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - fetch      │     100 │  314.64 req/sec │  ± 1.29 % │                       - │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ http - keepalive    │     100 │  600.19 req/sec │  ± 0.92 % │               + 90.75 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ http - no keepalive │     100 │  602.57 req/sec │  ± 0.89 % │               + 91.51 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - pipeline   │     100 │ 1653.26 req/sec │  ± 1.81 % │              + 425.44 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - request    │     100 │ 1905.69 req/sec │  ± 1.99 % │              + 505.67 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - stream     │     100 │ 2185.38 req/sec │  ± 2.05 % │              + 594.56 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - dispatch   │     100 │ 2602.14 req/sec │  ± 0.75 % │              + 727.02 % │

We could say that the major blocker are WHATWG streams, but I would not consider this "done".

We still need a 2x throughput increase

[RafaelGSS]

@mcollina today's release will include a perf improvement on webstream errors. It should improve a bit.

[mcollina]

There is a massive improvement in main:

│ Tests               │ Samples │          Result │ Tolerance │ Difference with slowest │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - fetch      │     100 │  432.22 req/sec │  ± 1.49 % │                       - │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ http - no keepalive │     100 │  598.51 req/sec │  ± 0.88 % │               + 38.47 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ http - keepalive    │     100 │  647.20 req/sec │  ± 0.84 % │               + 49.74 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - pipeline   │     100 │ 1616.99 req/sec │  ± 1.75 % │              + 274.11 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - request    │     100 │ 1900.22 req/sec │  ± 1.67 % │              + 339.64 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - stream     │     100 │ 2170.23 req/sec │  ± 2.06 % │              + 402.11 % │
|─────────────────────|─────────|─────────────────|───────────|─────────────────────────|
│ undici - dispatch   │     100 │ 2457.00 req/sec │  ± 1.79 % │              + 468.45 % │

We still need a rough +50% increase.