Skip to content

fix(Headers): lowercase name in Headers.prototype.set#1535

Merged
mcollina merged 1 commit intonodejs:mainfrom
KhafraDev:lowercase-headers-set
Jul 10, 2022
Merged

fix(Headers): lowercase name in Headers.prototype.set#1535
mcollina merged 1 commit intonodejs:mainfrom
KhafraDev:lowercase-headers-set

Conversation

@KhafraDev
Copy link
Copy Markdown
Member

Fixes a regression in a WPT from nodejs/node#43752

This is only an issue in Headers.prototype.set when using a header name that contains uppercase characters.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 10, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.90%. Comparing base (aa8782c) to head (38e0d1f).
⚠️ Report is 1961 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1535   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          50       50           
  Lines        4609     4610    +1     
=======================================
+ Hits         4374     4375    +1     
  Misses        235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 4340f0b into nodejs:main Jul 10, 2022
@KhafraDev KhafraDev deleted the lowercase-headers-set branch July 10, 2022 18:12
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants