feat: support mocking a reply with Uint8Arrays#3661
Closed
snovader wants to merge 1 commit intonodejs:mainfrom
Closed
feat: support mocking a reply with Uint8Arrays#3661snovader wants to merge 1 commit intonodejs:mainfrom
snovader wants to merge 1 commit intonodejs:mainfrom
Conversation
Contributor
|
I provided an alternative PR, which fixes this "better" and also tests it "properly" |
Author
|
Nice! I would go with your PR so I'll close this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Resolves #3660
Rationale
It was previously not possible to provide
MockInterceptor.replywith a Uint8Array and have those same bytes be returned as the result of a mocked requestChanges
Updated
getResponseDatato check for Uint8ArraysFeatures
Bug Fixes
Breaking Changes and Deprecations
Status