[BUG] npx with github scheme will fail without any message

[anatawa12]

Is there an existing issue for this?

• I have searched the existing issues

This issue exists in the latest npm version

• I am using the latest npm

Current Behavior

npx github:viperproject/check-license-header#v1

falls (exits 1) without any error message

Expected Behavior

npx github:viperproject/check-license-header#v1

run viperproject/check-license-header

Steps To Reproduce

1. With node 16.18.0 and npm 8.19.2
2. With no (additional) configuration
3. Run npx github:viperproject/check-license-header#v1

Environment

• npm: 8.19.2
• Node.js: v16.18.0
• OS Name: macOS Ventura 13.0
• System Model Name: MacBookPro 14-inch, 2021
• npm config:

; node bin location = /opt/n/bin/node
; node version = v16.18.0
; npm local prefix = /Users/anatawa12/IdeaProjects/fixRTM
; npm version = 8.19.2
; cwd = /Users/anatawa12/IdeaProjects/fixRTM
; HOME = /Users/anatawa12
; Run `npm config ls -l` to show all defaults.

[anatawa12]

I found npmBin passed to GitFetcher in pacote is path to npx-cli.js, not a npm and GitFetcher[_prepareDir] executes node npx-cli.js install <options....> so git dep preparation will be failed.

[anatawa12]

cli/lib/utils/config/flatten.js

Line 23 in 292156c

flat.npmBin = require.main ? require.main.filename

I think this line is the problem. the XXX says using npm programmatically is a bit of a pain.

[anatawa12]

And on the latest branch, here's the problem.
I've tested npm v9 but this problem still exiets.

cli/lib/utils/config/index.js

Lines 22 to 26 in bc5ec05

	// XXX make this the bin/npm-cli.js file explicitly instead
	// otherwise using npm programmatically is a bit of a pain.
	flat.npmBin = require.main ? require.main.filename
	: /* istanbul ignore next - not configurable property */ undefined
	flat.nodeBin = process.env.NODE || process.execPath

[nlf]

good catch! the mix up between the npx bin and the npm bin is definitely what's broken here

[milaninfy]

This appears to be fixed on latest npm

~ $ npx github:viperproject/check-license-header#v1 check
check-license-header check

Check license headers

Options:
      --version  Show version number                                   [boolean]
  -c, --config   Path to JSON config file                    [string] [required]
      --path     Path to working directory[string] [default: "/Users/milaninfy"]
  -h, --help     Show help                                             [boolean]
      --strict   Specifies whether files not covered by the configuration should
                 be treated as errors                 [boolean] [default: false]

Missing required argument: c
Please specify path to config file
~ $ npm -v
10.8.3
~ $ npx -v
10.8.3

[anatawa12]

it looks fixed by #6762