Merged
Conversation
claudiahdz
force-pushed
the
feat/publish
branch
2 times, most recently
from
0b58a78 to
3a0f260
Compare
isaacs
reviewed
Mar 10, 2020
14 tasks
claudiahdz
force-pushed
the
feat/publish
branch
3 times, most recently
from
4d8543b to
529111d
Compare
claudiahdz
force-pushed
the
feat/publish
branch
from
529111d to
daa17fd
Compare
isaacs
suggested changes
Mar 27, 2020
Contributor
isaacs
left a comment
isaacs
left a comment
There was a problem hiding this comment.
Only some pretty minor changes requested. This is looking great!
| } | ||
| }) | ||
| .tap(() => lifecycle(pkg, 'postpack', dir)) | ||
| const tarballs = await Promise.all(args.map((arg) => pack_(arg))) |
Contributor
There was a problem hiding this comment.
Since there's an await here, any errors will throw. Probably want to wrap this whole thing in a try { ... } catch (er) { cb(er) }
| defaultTag: 'latest', | ||
| json: false, | ||
| tmp: {}, | ||
| ...npm.flatOptions |
Contributor
There was a problem hiding this comment.
The aliasing is weird here, does libnpmpublish or libnpmpack do something with those?
Any reason you can't just pass npm.flatOptions in as the opts?
claudiahdz
force-pushed
the
feat/publish
branch
3 times, most recently
from
b9d0625 to
fbf0f01
Compare
isaacs
suggested changes
Mar 30, 2020
Contributor
isaacs
left a comment
isaacs
left a comment
There was a problem hiding this comment.
Just need to put the usage/completion on the exported function. Otherwise looks great!
claudiahdz
force-pushed
the
feat/publish
branch
from
fbf0f01 to
8e3ff7c
Compare
Contributor
|
💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors both
npm publishandnpm pack. Both now uselibnpmpackto pack tarballs andnpm publishno longer needs to write on disk to display to console the tarball contents.