Closed
Conversation
Author
|
waiting for approval of npm-lifecycle pull request to sync node-gyp versions and fix the error of the current pull request. |
added 2 commits
July 10, 2019 22:21
Contributor
|
This will be included in the next release. It took a bit of running around to update it in all the right places :) Thanks! |
This reverts commit 9a086be.
Author
Thank you @isaacs tests are failing due to some missing packages. If I execute "npm update" to fix it, tests about "npm search" fail due to some packages update like "call-limit", can you review it? |
This was referenced Aug 13, 2019
1 task
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
* fix: isolate flaky auth tests from host ADC credentials Fixes npm#206 Both test_load_credentials_no_options and test_get_token_env_var_empty_falls_through now override HOME to a temp dir and clear GOOGLE_APPLICATION_CREDENTIALS, preventing the well-known ADC path from matching on CI runners that have gcloud credentials. * refactor: use RAII EnvVarGuard for panic-safe env var cleanup in tests - Introduce EnvVarGuard struct that saves/restores env vars on Drop - Replace all manual save/restore patterns in auth tests - Fix bug where test_get_token_env_var_empty_falls_through did not restore GOOGLE_WORKSPACE_CLI_TOKEN - Ensures cleanup runs even if a test panics * fix: use var_os/OsString in EnvVarGuard for non-UTF-8 safety --------- Co-authored-by: jpoehnelt-bot <jpoehnelt-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps node-gyp from ^3.8.0 to ^5.0.2. We need this update due to adding Visual Studio 2019 support as I said here
Thank you!