Merged
Conversation
Use the defaut OTP explanation everywhere except when the context is "OTP-aware" (like when setting double-authentication)
jdeniau
force-pushed
the
otp-explanation-on-more-endpoints
branch
from
1a00846 to
7a3629b
Compare
zkat
approved these changes
Jul 20, 2018
Contributor
zkat
left a comment
zkat
left a comment
There was a problem hiding this comment.
Awesome! Thanks for recreating the PR. This looks great, and the rewording is 💯!
LGTM 👍
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
…non-interactive setup UX (npm#30) * fix: narrow default OAuth scopes to avoid restricted_client, add --full flag, improve non-interactive setup UX Fixes npm#24, npm#25 - DEFAULT_SCOPES now aliases MINIMAL_SCOPES (no pubsub/cloud-platform) which avoids Google's restricted_client 403 on unverified OAuth apps - Add FULL_SCOPES and --full flag for users who need the broader set - Replace cryptic 'run setup interactively' error with step-by-step manual OAuth console instructions including URLs, options A/B/C * chore: add changeset * chore: cargo fmt * fix: refactor format! with backslash continuations to concat! macro Address Gemini review (PR npm#30): replace hard-to-read backslash line continuations in large format! macros with concat! for clearer structure: - manual_oauth_instructions(): full step-by-step guide - stage_configure_oauth() wizard show_message: interactive prompt text No functional change; output text is identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-import of npm/npm#21119
Use the defaut OTP explanation everywhere except when the context is "OTP-aware" (like when setting double-authentication).
@zkat I followed your recommendation about
npm login, I just changed the message a little to be more understandable than the previous one, but not as verbose as the default one ;)