Skip to content

doc: Move @VERSION@ for html docs into gatsby#283

Closed
isaacs wants to merge 2 commits intorelease-6.13.0from
isaacs/move-VERSION-replacement
Closed

doc: Move @VERSION@ for html docs into gatsby#283
isaacs wants to merge 2 commits intorelease-6.13.0from
isaacs/move-VERSION-replacement

Conversation

@isaacs
Copy link
Copy Markdown
Contributor

@isaacs isaacs commented Nov 5, 2019

No description provided.

@isaacs isaacs requested a review from claudiahdz November 5, 2019 18:15
@isaacs isaacs requested a review from a team as a code owner November 5, 2019 18:15
@isaacs
Copy link
Copy Markdown
Contributor Author

isaacs commented Nov 5, 2019

Added second commit to fix the hyperlinks in the manpages.

Comment thread scripts/docs-build.js Outdated
@@ -12,18 +12,16 @@ fs.readFile(src, 'utf8', function (err, data) {

var fileExt = src.split('.').pop()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove this line too!

@isaacs isaacs force-pushed the isaacs/move-VERSION-replacement branch from 3bab3dc to 8287bf6 Compare November 5, 2019 18:31
@isaacs isaacs force-pushed the isaacs/move-VERSION-replacement branch from 8287bf6 to 6757077 Compare November 5, 2019 19:05
@ruyadorno ruyadorno closed this in 6700bfa Nov 5, 2019
@isaacs isaacs deleted the isaacs/move-VERSION-replacement branch October 2, 2020 21:41
Jah-yee pushed a commit to Jah-yee/cli that referenced this pull request Apr 16, 2026
* fix: handle array-of-arrays in CSV formatter

The CSV formatter assumed all items were JSON objects when collecting
column names. APIs that return arrays of arrays (e.g. Sheets values)
produced empty newlines instead of data.

Add an early return path for non-object arrays that emits each inner
array's elements as CSV cells directly, mirroring the table formatter's
existing "array of non-objects" handling.

Fixes npm#283

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test: add coverage for flat scalar CSV formatting

---------

Co-authored-by: Dan Rassi <129646+drassi@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants