version: fix -S argument passing for sign-git-commit#58
Merged
zkat merged 1 commit intorelease-nextfrom Aug 29, 2018
Merged
Conversation
Oops: 7984206 did the wrong thing with the git params, and it breaks anyone trying to sign their git commits with npm version. Fixes: https://npm.community/t/1661 Credit: @zkat
zkat
added a commit
that referenced
this pull request
Dec 10, 2018
Oops: 7984206 did the wrong thing with the git params, and it breaks anyone trying to sign their git commits with npm version. Fixes: https://npm.community/t/1661 Credit: @zkat
koralle
pushed a commit
to koralle/npm-cli
that referenced
this pull request
Feb 11, 2026
* feat(request): pretty output Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): pretty output fix test Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): pretty output fix function name `parsedResponseBody` Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): pretty output fix README Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): pretty output fix output format when direct`exclude` Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): `-o <path>` and `-O` option Signed-off-by: ysknsid25 <kengo071225@gmail.com> * format Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): `-J` and `--json` option Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): `-i` and `-I` option Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): update README.md Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): refactor function getOutputData Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): Pretty output resolve [object Object] when console.log to terminal Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): Pretty output fix return to continue Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): `-J` and `--json` option To be able to handle `application/json; charset=utf-8` Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): Pretty output show more rich http header Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): `-J` and `--json` option fix `formatResponseBody()` return type. string to string | object Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): `-o <path>` and `-O` option To be able to save when request to / Signed-off-by: ysknsid25 <kengo071225@gmail.com> * chore: format Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): `-J` and `--json` option fix indexOf to regular expressions Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): `-o <path>` and `-O` option For some contentTypes, set the extension Signed-off-by: ysknsid25 <kengo071225@gmail.com> * feat(request): `-o <path>` and `-O` option For some contentTypes, set the extension by using `hono/utils/mime` Signed-off-by: ysknsid25 <kengo071225@gmail.com> --------- Signed-off-by: ysknsid25 <kengo071225@gmail.com>
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
* feat: add gws mcp server
Adds a new `gws mcp` subcommand that starts a Model Context Protocol
(MCP) server over stdio, exposing Google Workspace APIs as structured
tools to any MCP-compatible client.
- New `src/mcp_server.rs`: JSON-RPC stdio transport, handles
`initialize`, `tools/list`, and `tools/call`
- Tool discovery dynamically builds schemas from Google Discovery Docs
- Filtering via `-s <services>` flag (e.g. `-s drive,gmail` or `-s all`)
- `-w/--workflows` and `-e/--helpers` flags for optional extras
- stderr startup warning when no services are configured
- Refactored `executor::execute_method` to support output capture
(returns `Option<Value>` instead of printing to stdout) so the MCP
transport is not corrupted
- Updated README.md with MCP Server section and usage examples
* fix: address PR review comments
- Add stderr warning when discovery doc fails to load (mcp_server.rs)
- Remove redundant 'all' string check in service validation (mcp_server.rs)
- Validate upload path to prevent arbitrary file reads - security fix (mcp_server.rs)
- Remove redundant inner capture_output check in handle_binary_response (executor.rs)
- Add changeset for minor version bump
* fix: resolve CI lint, fmt, and test failures
- cargo fmt: format all changed files
- clippy: add #[allow(clippy::too_many_arguments)] on private handle_json_response
- clippy: collapse else { if } to else if in executor.rs
- clippy: replace svc_name.clone() with std::slice::from_ref in mcp_server.rs
- clippy: replace index-based loop with iterator in walk path resolution
- test: add ::<()> turbofish annotation to handle_error_response test calls
to fix E0282 type inference errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oops: 7984206 did the
wrong thing with the git params, and it breaks anyone
trying to sign their git commits with npm version.
Fixes: https://npm.community/t/1661
Credit: @zkat
/cc @dpogue