fix: don't overwrite config keys unless they've really changed#6328
Merged
fix: don't overwrite config keys unless they've really changed#6328
Conversation
Member
wraithgar
commented
Apr 5, 2023
- fix: move to private attributes where possible
- fix: save raw data to file, not parsed data
Member
Author
|
npm tests fail w/ this, need to fix that first. |
wraithgar
commented
Apr 12, 2023
Member
Author
wraithgar
left a comment
There was a problem hiding this comment.
👍 on the last mile fix, thanks!
_loadError and _valid still have some magic to them
When ${X} values are read from an rc file, those values should be written back as-is when config is re-saved
Fixes #6183
baa1a79 to
a7fadc2
Compare
Collaborator
|
no statistically significant performance changes detected timing results
|
Merged
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.