Release 6.13.5 by ruyadorno · Pull Request #666 · npm/cli

ruyadorno · 2020-01-07T20:07:11Z

6.13.5 (2020-01-09)

BUG FIXES

fd0a802ec #550 Fix cache location for npm ci (@zhenyavinogradov)
4b30f3cca #648 fix(version): using 'allow-same-version', git commit --allow-empty and git tag -f (@rhengles)

TESTING

e16f68d30 test(ci): add failing cache config test (@ruyadorno)
3f009fbf2 #659 test: fix bin-overwriting test on Windows (@isaacs)
43ae0791f #601 ci: Allow builds to run even if one fails (@XhmikosR)
4a669bee4 #603 Remove the unused appveyor.yml (@XhmikosR)
9295046ac #600 ci: switch to actions/checkout@v2 (@XhmikosR)

DOCUMENTATION

f2d770ac7 #569 fix netlify publish path config (@claudiahdz)
462cf0983 #627 update gatsby dependencies (@felixonmars)
6fb5dbb72 #532 docs: clarify usage of global prefix (@jgehrcke)

@felixonmars

PR-URL: #627 Credit: @felixonmars Close: #627 Reviewed-by: @ruyadorno

@claudiahdz

PR-URL: #569 Credit: @claudiahdz Close: #569 Reviewed-by: @ruyadorno

@zhenyavinogradov

When you set `<cache>` directory in npm config, `npm ci` has been using `<cache>` for storing the cache instead of `<cache>/_cacache` PR-URL: #550 Credit: @zhenyavinogradov Close: #550 Reviewed-by: @ruyadorno

@XhmikosR

This will allow all builds to run even if one fails PR-URL: #601 Credit: @XhmikosR Close: #601 Reviewed-by: @ruyadorno

@XhmikosR

PR-URL: #603 Credit: @XhmikosR Close: #603 Reviewed-by: @ruyadorno

@XhmikosR

PR-URL: #600 Credit: @XhmikosR Close: #600 Reviewed-by: @ruyadorno

@ruyadorno

Paired with @ruyadorno PR-URL: #659 Credit: @isaacs Close: #659 Reviewed-by: @ruyadorno

npm-deploy-user · 2020-01-09T17:18:58Z

	angular-quickstart			app-large			app-medium			ember-quickstart			react-app
	prev	current	status	prev	current	status	prev	current	status	prev	current	status	prev	current	status
initial install	38.3s	39.8s	✅🐌	36.7s	37.8s	✅🐌	32.4s	33.5s	✅🐌	26.3s	26.6s	✅🐌	30.6s	31.8s	✅🐌
repeat install	8.7s	9.2s	✅🐌	8.9s	8.3s	✅	8s	8.5s	✅🐌	6.9s	7.5s	✅🐌	8.4s	9s	✅🐌
with warm cache	29.1s	30.5s	✅🐌	31.7s	32.7s	✅🐌	27.2s	29.1s	✅🐌	22.4s	23.7s	✅🐌	26.9s	28.5s	✅🐌
with node_modules	8.6s	9.4s	✅🐌	7.7s	7.8s	✅🐌	8s	8.8s	✅🐌	6.9s	7.4s	✅🐌	8.3s	9s	✅🐌
with lockfile	27.3s	28.6s	✅🐌	31.5s	31.1s	✅	28.9s	27.3s	✅	19.3s	21.5s	🛑	24.3s	26.5s	✅🐌
with warm cache and node_modules	9s	9.2s	✅🐌	8.4s	8.9s	✅🐌	8s	8.3s	✅🐌	7.1s	7.5s	✅🐌	8.4s	9s	✅🐌
with warm cache and lockfile	22.8s	24.4s	✅🐌	24.8s	27.1s	✅🐌	23.2s	23.8s	✅🐌	15.5s	16.2s	✅🐌	20.4s	21.4s	✅🐌
with node_modules and lockfile	9.3s	9.8s	✅🐌	8.6s	8.9s	✅🐌	8.6s	10s	🛑	7.3s	7.5s	✅🐌	9.2s	9.4s	✅🐌

- Moved windows builds to travis-only since they're currently failing on GHA and it's not code-related - Added setup on GHA config to only run coverage once in ubuntu target

@rhengles

…nd git tag -f PR-URL: #648 Credit: @rhengles Close: #648 Reviewed-by: @ruyadorno

@jgehrcke

In wondered why npm link doesn't "install to" `npm prefix`. I looked up the documentation for `npm prefix` and found the important distinction between the local prefix, and the global prefix. This attempts to clarity that `npm link` always uses specifically the global prefix. PR-URL: #532 Credit: @jgehrcke Close: #532 Reviewed-by: @ruyadorno

XhmikosR · 2020-01-10T08:25:30Z

@ruyadorno I'm mostly on Windows, so I might be able to pinpoint the Windows failures. I'll experiment on my fork, because ideally everything should be tested in one place.

ruyadorno · 2020-01-10T16:29:32Z

@XhmikosR thanks! that's really appreciated 😊 (I assume you're talking about e0a7a2f)

It was not that big of a problem for this release since we still had the travis build around anyways but it would be definitely nice to track down what is happening and fix it.

I can share some of the findings from our team so that you can get a head start, for now the problems only occur in the GitHub actions environment (we couldn't reproduce it on our local windows environments) and are related to npm run executing node scripts (from within the tests) that contains hash bangs, usually they should be ignored on windows, so it might be something in that specific environment that we're not accounting for in https://github.com/npm/cmd-shim 🤔

XhmikosR · 2020-01-10T17:13:30Z

@ruyadorno : thanks for the info :)

That being said it seems CI is passing fine on my fork on Windows https://github.com/XhmikosR/cli-1/runs/383031136

Maybe you should try re-enabling it? BTW you can force the shell to be something other than the default which is powershell. https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#using-a-specific-shell

felixonmars and others added 7 commits January 6, 2020 18:38

docs: update gatsby dependencies

462cf09

PR-URL: #627 Credit: @felixonmars Close: #627 Reviewed-by: @ruyadorno

chore: fix netlify publish path config

f2d770a

PR-URL: #569 Credit: @claudiahdz Close: #569 Reviewed-by: @ruyadorno

test(ci): add failing cache config test

e16f68d

Fix cache location for npm ci

fd0a802

When you set `<cache>` directory in npm config, `npm ci` has been using `<cache>` for storing the cache instead of `<cache>/_cacache` PR-URL: #550 Credit: @zhenyavinogradov Close: #550 Reviewed-by: @ruyadorno

CI: add fail-fast: false

43ae079

This will allow all builds to run even if one fails PR-URL: #601 Credit: @XhmikosR Close: #601 Reviewed-by: @ruyadorno

Remove the unused appveyor.yml

4a669be

PR-URL: #603 Credit: @XhmikosR Close: #603 Reviewed-by: @ruyadorno

CI: switch to actions/checkout@v2

9295046

PR-URL: #600 Credit: @XhmikosR Close: #600 Reviewed-by: @ruyadorno

ruyadorno requested a review from a team as a code owner January 7, 2020 20:07

Fix bin-overwriting test on Windows

3f009fb

Paired with @ruyadorno PR-URL: #659 Credit: @isaacs Close: #659 Reviewed-by: @ruyadorno

ruyadorno force-pushed the release-6.13.5 branch from 2fe00b9 to a5496c0 Compare January 9, 2020 17:04

ruyadorno and others added 3 commits January 9, 2020 15:22

chore: ci cleanup

e0a7a2f

- Moved windows builds to travis-only since they're currently failing on GHA and it's not code-related - Added setup on GHA config to only run coverage once in ubuntu target

feat(version): using 'allow-same-version', git commit --allow-empty a…

4b30f3c

…nd git tag -f PR-URL: #648 Credit: @rhengles Close: #648 Reviewed-by: @ruyadorno

ruyadorno force-pushed the release-6.13.5 branch from c4e464e to 6fb5dbb Compare January 9, 2020 20:24

ruyadorno added 3 commits January 9, 2020 15:49

docs: changelog for 6.13.5

4812866

update AUTHORS

e099866

6.13.5

787bb66

ruyadorno merged commit 787bb66 into latest Jan 9, 2020

isaacs deleted the release-6.13.5 branch August 19, 2021 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 6.13.5#666

Release 6.13.5#666
ruyadorno merged 14 commits intolatestfrom
release-6.13.5

ruyadorno commented Jan 7, 2020 •

edited

Loading

Uh oh!

npm-deploy-user commented Jan 9, 2020 •

edited

Loading

Uh oh!

XhmikosR commented Jan 10, 2020

Uh oh!

ruyadorno commented Jan 10, 2020

Uh oh!

XhmikosR commented Jan 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

ruyadorno commented Jan 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

6.13.5 (2020-01-09)

BUG FIXES

TESTING

DOCUMENTATION

Uh oh!

npm-deploy-user commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XhmikosR commented Jan 10, 2020

Uh oh!

ruyadorno commented Jan 10, 2020

Uh oh!

XhmikosR commented Jan 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ruyadorno commented Jan 7, 2020 •

edited

Loading

npm-deploy-user commented Jan 9, 2020 •

edited

Loading