Support nested modules with namespaced plugin/proxy/log names#128
Open
Support nested modules with namespaced plugin/proxy/log names#128
Conversation
Contributor
Author
|
Ok, so this is working correctly for application modules nested along with core modules. Core modules need the naming to come from the base module name ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #127 and keeps all the hacks hidden away in NxusModule still?
Note that there are many different paths for determining the directory path prefix:
getProxyin a module file before it is exported.getProxyis only called next to module class definitionPluginManager_moduleNamelogic in effect for "Loading" message, but if using a module that has_moduleNamethis will be favored by the time the Application proxies etc.