You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we're going to change all these function signatures now, I think we should future-proof this by using a config dict with a dir key rather than a cogs_dir string. What do you think?
This code passes around the cogs_dir string so that you can call a utility function to read required configuration data out of some file in the .cogs/ directory. The alternative is to pass around the configuration data.
In our case, everything we need should be stored in a file somewhere in .cogs/, and there's no point in loading it until we need it. So after giving it some thought, now I think that passing around the cogs_dir string is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #84
The
vaidate_cogs_project()method now returns the abs path of the.cogsdirectory to allow callingcogscommands from child directories.