Redo OTLPMetricExporter unit tests of max_export_batch_size to use real export#5036
Merged
xrmx merged 4 commits intoopen-telemetry:mainfrom Apr 3, 2026
Merged
Conversation
xrmx
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Full redo of the HTTP OTLPMetricExporter unit tests of
max_export_batch_sizebecause they weren't using realexport. It should be realOTLPMetricExporter.exportnow whileSession.postis mocked at the HTTP level. The old tests also weren't the most readable, so I've factored out a helper to generate the metrics_data exported.Fixes #5035
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e py312-test-opentelemetry-exporter-otlp-proto-httpDoes This PR Require a Contrib Repo Change?
Checklist: