Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b302246565
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| unless key.nil? | ||
| name = ERB::Util.url_encode(key.to_s) | ||
| y << "; name=\"#{name}\"" | ||
| y << "; name=\"#{key}\"" |
There was a problem hiding this comment.
Escape multipart field names before quoting
Interpolating key directly into name="..." can generate invalid or injected Content-Disposition parameters when multipart keys contain ", \\, or CR/LF (possible for user-supplied/custom body hashes). Before this change, url_encode prevented those control characters from terminating the quoted string; now the emitted part headers can be malformed and parsed incorrectly by servers. Please escape quoted-string meta characters (and reject CR/LF) before writing the header value.
Useful? React with 👍 / 👎.
5ce251c to
91c493d
Compare
615b1b0 to
602fe81
Compare
602fe81 to
c97904c
Compare
c97904c to
caedb8e
Compare
caedb8e to
7a4069a
Compare
7a4069a to
ad7b1b4
Compare
ad7b1b4 to
5a06c55
Compare
5a06c55 to
d862c7c
Compare
d862c7c to
a5d5ec3
Compare
Automated Release PR
0.58.0 (2026-04-04)
Full Changelog: v0.57.0...v0.58.0
Features
Bug Fixes
Chores
Documentation
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions