Open
Conversation
Literal build_secrets values in stack.yaml are no longer supported. Update examples to use file paths and replace faas-cli pro references with faas-cli build. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewSummary
Approval rating (1-10)9 Summary per fileSummary per file
Overall AssessmentThe changes appropriately update the documentation to reflect that Detailed ReviewDetailed Review_posts/2026-03-24-encrypted-build-secrets.md
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the encrypted build secrets blog post to reflect that literal
build_secretsvalues instack.yamlare no longer supported. Examples now use file paths andfaas-cli pro buildreferences are replaced withfaas-cli build.Motivation and Context
Literal
build_secretsvalues instack.yamlare no longer supported. Values must be file paths.Have you applied the editorial and style guide to your post?
Yes
How have you tested the instructions for any tutorial steps?
Reviewed changes for accuracy.
Types of changes
Checklist:
git commit -s