Skip to content

Update build secrets blog post#358

Open
welteki wants to merge 1 commit intoopenfaas:masterfrom
welteki:update-blog-build-secrets-file-paths
Open

Update build secrets blog post#358
welteki wants to merge 1 commit intoopenfaas:masterfrom
welteki:update-blog-build-secrets-file-paths

Conversation

@welteki
Copy link
Copy Markdown
Member

@welteki welteki commented Apr 2, 2026

Description

Update the encrypted build secrets blog post to reflect that literal build_secrets values in stack.yaml are no longer supported. Examples now use file paths and faas-cli pro build references are replaced with faas-cli build.

Motivation and Context

Literal build_secrets values in stack.yaml are no longer supported. Values must be file paths.

Have you applied the editorial and style guide to your post?

Yes

How have you tested the instructions for any tutorial steps?

Reviewed changes for accuracy.

Types of changes

  • New blog post
  • Updating an existing blog post
  • Updating part of an existing page
  • Adding a new page

Checklist:

  • I have given attribution for any images I have used and have permission to use them under Copyright law
  • My code follows the writing-style of the publication and I have checked this
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

Literal build_secrets values in stack.yaml are no longer supported.
Update examples to use file paths and replace faas-cli pro references
with faas-cli build.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
@reviewfn
Copy link
Copy Markdown

reviewfn bot commented Apr 2, 2026

AI Pull Request Overview

Summary

  • Updated blog post on encrypted build secrets to remove support for literal values in build_secrets
  • Changed examples to use file paths instead of inline values
  • Replaced faas-cli pro build references with faas-cli build
  • Updated documentation link anchor from #plugins-and-build-time-secrets to #build-time-secrets
  • Added instructions for creating secret files before referencing them in stack.yaml
  • Modified wrapping up section to remove pro build reference

Approval rating (1-10)

9

Summary per file

Summary per file
File path Summary
_posts/2026-03-24-encrypted-build-secrets.md Updated examples to use file paths for build_secrets, removed literal value support

Overall Assessment

The changes appropriately update the documentation to reflect that build_secrets in stack.yaml no longer accepts literal values and must use file paths. The command references have been updated from faas-cli pro build to faas-cli build. No technical inaccuracies or security risks identified in the updated content.

Detailed Review

Detailed Review

_posts/2026-03-24-encrypted-build-secrets.md

  • The change from literal build_secrets values to file paths aligns with the stated API changes and improves security by avoiding plaintext secrets in configuration files.
  • Added file creation steps (mkdir -p .secrets and echo -n commands) provide clear guidance for users, reducing potential configuration errors.
  • Command reference updates from faas-cli pro build to faas-cli build appear consistent with current CLI naming.
  • Link anchor update to #build-time-secrets should be verified against the actual documentation to ensure it resolves correctly.
  • No issues with the sealed secret examples or CI pipeline instructions.
  • Risk: If the documentation link does not exist or the anchor is incorrect, users following the tutorial may encounter broken navigation. Recommend testing the link in the live docs.

AI agent details.

Agent processing time: 26.484s
Environment preparation time: 6.1s
Total time from webhook: 47.463s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant