Add graylog service #147
Closed
quitterie-lcs wants to merge 1 commit intomasterfrom
Closed
Conversation
quitterie-lcs
force-pushed
the
backends-add-graylog-service
branch
2 times, most recently
from
f368ea9 to
c5aee65
Compare
jmaupetit
reviewed
Sep 29, 2021
jmaupetit
reviewed
Oct 4, 2021
jmaupetit
reviewed
Oct 7, 2021
jmaupetit
reviewed
Oct 13, 2021
jmaupetit
reviewed
Oct 13, 2021
quitterie-lcs
force-pushed
the
backends-add-graylog-service
branch
from
a9c618d to
daa459d
Compare
quitterie-lcs
force-pushed
the
backends-add-graylog-service
branch
5 times, most recently
from
c68144f to
e995c39
Compare
quitterie-lcs
force-pushed
the
backends-add-graylog-service
branch
2 times, most recently
from
02ac0fc to
b7a07c6
Compare
quitterie-lcs
force-pushed
the
backends-add-graylog-service
branch
4 times, most recently
from
2dc2e83 to
8d20434
Compare
jmaupetit
reviewed
Nov 30, 2021
Contributor
jmaupetit
left a comment
jmaupetit
left a comment
There was a problem hiding this comment.
Looks great 💪
Remarks:
- Instructions to run/access the graylog server are missing in the project's README
- Should we pre-configure the graylog server in development (create and activate inputs, create streams)?
SergioSim
reviewed
Dec 6, 2021
Collaborator
SergioSim
left a comment
SergioSim
left a comment
There was a problem hiding this comment.
Beautiful work!
Have only minor suggestions.
quitterie-lcs
force-pushed
the
backends-add-graylog-service
branch
2 times, most recently
from
7bccd8f to
ef36d57
Compare
jmaupetit
reviewed
Jan 3, 2022
| def search_logs(self, params): | ||
| """Returns logs matching given `params` parameters.""" | ||
|
|
||
| return self.get("/api/search/universal/relative", params=params) |
Contributor
There was a problem hiding this comment.
I did not found documentation for this endpoint. Can you point me to it?
quitterie-lcs
force-pushed
the
backends-add-graylog-service
branch
2 times, most recently
from
1afe63e to
aa1eda6
Compare
quitterie-lcs
force-pushed
the
backends-add-graylog-service
branch
from
aa1eda6 to
66e11f8
Compare
quitterie-lcs
force-pushed
the
backends-add-graylog-service
branch
from
66e11f8 to
e360c46
Compare
Contributor
|
Opened issue #475 and closing this PR as it is too far from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
LDP backends is available for tests.But until now, no service was available in the project.
Proposal