build: update golang k8s API's to v0.23#136
Conversation
|
Please explain that this is upgrading to k8s v1.23 api in the PR title and commit msg |
|
|
||
| require ( | ||
| github.com/go-logr/logr v0.4.0 | ||
| github.com/go-logr/logr v1.2.0 |
There was a problem hiding this comment.
- seeing CI pass is a good sign however pls do test locally once
- iirc some combo of logr and controller-runtime failed during the initial stages of the project
There was a problem hiding this comment.
@iamniting , I will merge this once you confirm that the local tests pass.
There was a problem hiding this comment.
I am able to deploy it successfully without any issues and PVC creation was also successful. There was no problem with logs as well.
Verified the changes done in the second commit too they look good to me.
$ kubectl get pods
NAME READY STATUS RESTARTS AGE
lvm-operator-controller-manager-6698c4fc6d-tsbwf 3/3 Running 0 7m18s
topolvm-controller-7647b95dd-vc6ld 4/4 Running 0 83s
topolvm-node-62l7d 4/4 Running 0 83s
vg-manager-d4c8t 1/1 Running 0 82s
sh-4.4# pvs
PV VG Fmt Attr PSize PFree
/dev/nvme0n1 vg1 lvm2 a-- <1.46t <1.46t
/dev/nvme1n1 vg1 lvm2 a-- <1.46t <1.46t
/dev/nvme2n1 vg1 lvm2 a-- <1.46t <1.46t
sh-4.4# vgs
VG #PV #LV #SN Attr VSize VFree
vg1 3 0 0 wz--n- <4.37t <4.37t
$ kubectl get storageclass
NAME PROVISIONER RECLAIMPOLICY VOLUMEBINDINGMODE ALLOWVOLUMEEXPANSION AGE
odf-lvm-vg1 topolvm.cybozu.com Delete WaitForFirstConsumer true 3m32s
$ kubectl get pvc
NAME STATUS VOLUME CAPACITY ACCESS MODES STORAGECLASS AGE
lvm-block-pvc Bound pvc-87cda619-32d4-4b5a-9a93-94277246f7fa 5Gi RWO odf-lvm-vg1 7s
lvm-file-pvc Bound pvc-63bf5fc6-070e-4055-a0f4-1e2ecfa323c2 5Gi RWO odf-lvm-vg1 67s
$ kubectl get pod | grep -E '^(app|NAME)'
NAME READY STATUS RESTARTS AGE
app-block 1/1 Running 0 11s
app-file 1/1 Running 0 60s
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
update Handler to the ProbeHandler or LifecycleHandler based on the usage. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iamniting, leelavg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/lgtm /approve |
Signed-off-by: Nitin Goyal nigoyal@redhat.com