Skip to content

build: update golang k8s API's to v0.23#136

Merged
nbalacha merged 3 commits intoopenshift:mainfrom
iamniting:update-api
Mar 25, 2022
Merged

build: update golang k8s API's to v0.23#136
nbalacha merged 3 commits intoopenshift:mainfrom
iamniting:update-api

Conversation

@iamniting
Copy link
Copy Markdown
Member

Signed-off-by: Nitin Goyal nigoyal@redhat.com

@nbalacha
Copy link
Copy Markdown
Contributor

Please explain that this is upgrading to k8s v1.23 api in the PR title and commit msg


require (
github.com/go-logr/logr v0.4.0
github.com/go-logr/logr v1.2.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • seeing CI pass is a good sign however pls do test locally once
  • iirc some combo of logr and controller-runtime failed during the initial stages of the project

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamniting , I will merge this once you confirm that the local tests pass.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to deploy it successfully without any issues and PVC creation was also successful. There was no problem with logs as well.

Verified the changes done in the second commit too they look good to me.

$ kubectl get pods
NAME                                               READY   STATUS    RESTARTS   AGE
lvm-operator-controller-manager-6698c4fc6d-tsbwf   3/3     Running   0          7m18s
topolvm-controller-7647b95dd-vc6ld                 4/4     Running   0          83s
topolvm-node-62l7d                                 4/4     Running   0          83s
vg-manager-d4c8t                                   1/1     Running   0          82s
sh-4.4# pvs
  PV           VG  Fmt  Attr PSize  PFree 
  /dev/nvme0n1 vg1 lvm2 a--  <1.46t <1.46t
  /dev/nvme1n1 vg1 lvm2 a--  <1.46t <1.46t
  /dev/nvme2n1 vg1 lvm2 a--  <1.46t <1.46t
sh-4.4# vgs
  VG  #PV #LV #SN Attr   VSize  VFree 
  vg1   3   0   0 wz--n- <4.37t <4.37t
$ kubectl get storageclass
NAME          PROVISIONER          RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
odf-lvm-vg1   topolvm.cybozu.com   Delete          WaitForFirstConsumer   true                   3m32s
$ kubectl get pvc
NAME            STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
lvm-block-pvc   Bound    pvc-87cda619-32d4-4b5a-9a93-94277246f7fa   5Gi        RWO            odf-lvm-vg1    7s
lvm-file-pvc    Bound    pvc-63bf5fc6-070e-4055-a0f4-1e2ecfa323c2   5Gi        RWO            odf-lvm-vg1    67s
$ kubectl get pod | grep -E '^(app|NAME)'
NAME                                               READY   STATUS    RESTARTS   AGE
app-block                                          1/1     Running   0          11s
app-file                                           1/1     Running   0          60s

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
update Handler to the ProbeHandler or LifecycleHandler based on the
usage.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting iamniting changed the title build: update golang API's build: update golang k8s API's to v0.23 Mar 24, 2022
Copy link
Copy Markdown
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iamniting, leelavg
To complete the pull request process, please assign nbalacha after the PR has been reviewed.
You can assign the PR to them by writing /assign @nbalacha in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha
Copy link
Copy Markdown
Contributor

/lgtm /approve

@nbalacha nbalacha merged commit fc611e4 into openshift:main Mar 25, 2022
@iamniting iamniting deleted the update-api branch April 13, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants