fix: fix ensureCreated of lvmVG via returning an error#139
Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom Apr 4, 2022
Merged
fix: fix ensureCreated of lvmVG via returning an error#139openshift-merge-robot merged 1 commit intoopenshift:mainfrom
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Conversation
nbalacha
reviewed
Apr 4, 2022
iamniting
force-pushed
the
lvm_volumegroup
branch
from
968da6a to
c2cac7b
Compare
The func does not return an error if there is an error and always return nil. Fix the same via returning and error if there is a failure. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
iamniting
force-pushed
the
lvm_volumegroup
branch
from
c2cac7b to
c478b0f
Compare
nbalacha
approved these changes
Apr 4, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The func does not return an error if there is an error and always return
nil. Fix the same via returning and error if there is a failure.
Signed-off-by: Nitin Goyal nigoyal@redhat.com