test: refactor and addition of CR deletion test

[leelavg]

• use envtest for verifying reconciliation of lvm cluster CR

Signed-off-by: Leela Venkaiah G lgangava@redhat.com

[jmolmo]

IMHO we are not testing the functionality of the controller. I mean we are just checking that controller runtime client works properly using a CRD. And that is something that has been already verified in the client package.

I think that it has more meaning and utility for us the test proposed in #13, where after the creation of the lvmcluster CRD we verified the existence of the CSIDriver resource and topolvm deployment.

In any case ... is difficult for me to see this kind of test as "unit test" ,,, is more like a mix between integration test (without CI env) and "extended" unit tests.

[leelavg]

And that is something that has been already verified in the client package

• It was verified for an example resource creation, in our case we want to test creation of our CR with default spec for now and check status is true & reconciliation started and working as expected

I think that it has more meaning and utility for us the test proposed in #13

• the said pr will be split into three and this is the first one where I'm trying to create a layout for e2e-ish kind of flow and rest of 2 prs will build up on this layout

In any case ... is difficult for me to see this kind of test as "unit test" ,,, is more like a mix between integration test (without CI env) and "extended" unit tests.

• yep, it's arguable, in a unit test-ish setup we have test spies, mocks/fakes etc however I don't want to stop moving forward to decide on how unit tests should look like at this point/pace of development 😅

IMHO, if we had flow charts then it suites better to commit failing tests first and then code to fix those tests

I'm open to suggestions on how good to refactor tests or what should be tested as part of unit tests and e2e tests.

Pls correct me if I presented something not relatable/right 😀

[jmolmo]

I wonder is we can use the structure of this test to do all the "unit test" for all the "functional units".
We need always to create the lvm cluster and start the reconcile loop, after that ,, the verification we need to do for each unit are basically the same ( the unit is created, deployed, and it is composed by several containers) .

[leelavg]

@jmolmo yes, that's the plan.

The current pr creates a basic skeleton and individual component owners add their units with their implementation.