Skip to content

OCPBUGS-30266: fix: introduce minimum allocation sizes#603

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jakobmoellerdev:fixup-minimum-provisioning
Apr 12, 2024
Merged

OCPBUGS-30266: fix: introduce minimum allocation sizes#603
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jakobmoellerdev:fixup-minimum-provisioning

Conversation

@jakobmoellerdev
Copy link
Copy Markdown
Contributor

This introduces minimum allocation sizing on the topolvm controller server equivalent to our upstream. The difference here is that we set our own limits so that we can later transition to a more dynamic configuration if required. For now the minimum limits should suffice.

Signed-off-by: Jakob Möller <jmoller@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 10, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-30266, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This introduces minimum allocation sizing on the topolvm controller server equivalent to our upstream. The difference here is that we set our own limits so that we can later transition to a more dynamic configuration if required. For now the minimum limits should suffice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2024
@jakobmoellerdev
Copy link
Copy Markdown
Contributor Author

/test all

@jakobmoellerdev
Copy link
Copy Markdown
Contributor Author

/override ci/prow/snyk-deps

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2024

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps

Details

In response to this:

/override ci/prow/snyk-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review April 10, 2024 16:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2024
@openshift-ci openshift-ci bot requested review from jeff-roche and jerpeter1 April 10, 2024 16:03
@jakobmoellerdev
Copy link
Copy Markdown
Contributor Author

/test all

@jakobmoellerdev
Copy link
Copy Markdown
Contributor Author

/test unit-test

@jakobmoellerdev
Copy link
Copy Markdown
Contributor Author

/override ci/prow/snyk-deps

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 11, 2024

@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps

Details

In response to this:

/override ci/prow/snyk-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 11, 2024

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jeff-roche
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jakobmoellerdev,jeff-roche]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jakobmoellerdev
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 12, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-30266, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from radeore April 12, 2024 06:29
@openshift-merge-bot openshift-merge-bot bot merged commit 7770551 into openshift:main Apr 12, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@jakobmoellerdev: An error was encountered updating to the MODIFIED state for bug OCPBUGS-30266 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. No response returned: Get "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-30266/transitions?expand=transitions.fields": GET https://issues.redhat.com/rest/api/2/issue/OCPBUGS-30266/transitions?expand=transitions.fields giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

This introduces minimum allocation sizing on the topolvm controller server equivalent to our upstream. The difference here is that we set our own limits so that we can later transition to a more dynamic configuration if required. For now the minimum limits should suffice.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jakobmoellerdev
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@jakobmoellerdev: Jira Issue OCPBUGS-30266: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30266 has been moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants