OCPEDGE-922: Bring more visibility to dynamic device discovery by warnings and a new status field

[suleymanakbas91]

This PR adds some admission warnings and more visibility through a status field in LVMCluster CRD in case the dynamic device discovery is enabled by not setting a DeviceSelector.

The new status field is called DeviceDiscoveryPolicy:

• If set to DeviceDiscoveryPolicyPreconfigured, the devices are preconfigured through a DeviceSelector.
• If set to DeviceDiscoveryPolicyRuntimeDynamic, the devices are added to the VG if they are present at runtime.

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPEDGE-922 which is a valid jira issue.

Details

In response to this:

This PR adds some admission warnings and more visibility through a status field in LVMCluster CRD in case the dynamic device discovery is enabled by not setting a DeviceSelector.

The new status field is called DeviceDiscoveryPolicy:

• If set to DeviceDiscoveryPolicyPreConfigured, the devices are preconfigured through a DeviceSelector.
• If set to DeviceDiscoveryPolicyRuntimeDynamic, the devices are added to the VG if they are present at runtime.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jakobmoellerdev]

Nice addition and not as crazy as my previous attempt. Overall lgtm, just a few minor things for docs and a small nit on the warning generation

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (7a7d364) to head (5fde32c).
Report is 2 commits behind head on main.

❗ Current head 5fde32c differs from pull request most recent head 2e057bf. Consider uploading reports for the commit 2e057bf to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
+ Coverage   77.66%   77.75%   +0.09%     
==========================================
  Files          27       27              
  Lines        1952     1960       +8     
==========================================
+ Hits         1516     1524       +8     
  Misses        319      319              
  Partials      117      117              

Files	Coverage Δ
api/v1alpha1/lvmcluster_webhook.go	83.72% <100.00%> (+0.30%)	⬆️
api/v1alpha1/lvmvolumegroupnodestatus_types.go	100.00% <ø> (ø)
internal/controllers/vgmanager/status.go	78.94% <100.00%> (+0.76%)	⬆️

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPEDGE-922 which is a valid jira issue.

Details

In response to this:

This PR adds some admission warnings and more visibility through a status field in LVMCluster CRD in case the dynamic device discovery is enabled by not setting a DeviceSelector.

The new status field is called DeviceDiscoveryPolicy:

• If set to DeviceDiscoveryPolicyPreconfigured, the devices are preconfigured through a DeviceSelector.
• If set to DeviceDiscoveryPolicyRuntimeDynamic, the devices are added to the VG if they are present at runtime.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jakobmoellerdev]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment