Skip to content

OCPBUGS-36155: Disallow changing node selector after initial deployment#649

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
suleymanakbas91:val-node-selector
Jun 27, 2024
Merged

OCPBUGS-36155: Disallow changing node selector after initial deployment#649
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
suleymanakbas91:val-node-selector

Conversation

@suleymanakbas91
Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 27, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-36155, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.78%. Comparing base (748fb1b) to head (53bac03).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   58.33%   57.78%   -0.55%     
==========================================
  Files          54       53       -1     
  Lines        4258     4212      -46     
==========================================
- Hits         2484     2434      -50     
- Misses       1525     1533       +8     
+ Partials      249      245       -4     
Files Coverage Δ
api/v1alpha1/lvmcluster_webhook.go 84.36% <76.92%> (-0.43%) ⬇️

... and 5 files with indirect coverage changes

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
@suleymanakbas91
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 27, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-36155, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 27, 2024
@openshift-ci openshift-ci bot requested a review from radeore June 27, 2024 09:15
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 27, 2024

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bf9fc3a into openshift:main Jun 27, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@suleymanakbas91: Jira Issue OCPBUGS-36155: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36155 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@suleymanakbas91 suleymanakbas91 deleted the val-node-selector branch June 27, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants