OCPEDGE-1247: make thin pool config editable#708
OCPEDGE-1247: make thin pool config editable#708openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@qJkee: This pull request references OCPEDGE-1084 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qJkee The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
qJkee
changed the title
|
@qJkee: This pull request references OCPEDGE-1247 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@qJkee: This pull request references OCPEDGE-1247 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Make editable overprovisionRatio field in thin pool device class at lvm cluster
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
+ Coverage 69.30% 70.19% +0.89%
==========================================
Files 49 49
Lines 3313 3342 +29
==========================================
+ Hits 2296 2346 +50
+ Misses 841 825 -16
+ Partials 176 171 -5
|
|
/test e2e-aws |
|
/test e2e-aws |
1 similar comment
|
/test e2e-aws |
jakobmoellerdev
left a comment
jakobmoellerdev
left a comment
There was a problem hiding this comment.
Just a comment regarding the custom DeepCopy other than that looks okay to me.
A general question: How does TopoLVM behave when overprovisioning is reduced to a limit that is already reached?
| maxReadLength = 2 * 1 << 20 // 2MB | ||
| ) | ||
|
|
||
| func DeepCopyConfig(c *Config) *Config { |
There was a problem hiding this comment.
Why do you need this? Couldnt you just deref and reref the Config? Or use deepcopy gen?
There was a problem hiding this comment.
Deref is not working because we have pointers inside. We can generate a deep copy if you think this will be better.
Looks like it works. That's why I did request additional testing from QE |
openshift-merge-robot
added
the
needs-rebase
|
What do you mean with it works? It should not be able to overprovision. If that is not prohibited then we need to fix that in upstream |
openshift-merge-robot
removed
the
needs-rebase
qJkee
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
|
@qJkee: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
Make editable overprovisionRatio field in thin pool device class at lvm cluster