Skip to content

feat: adds the new LVMVolumeGroup CRD#71

Merged
nbalacha merged 1 commit intoopenshift:mainfrom
nbalacha:new-crd
Jan 13, 2022
Merged

feat: adds the new LVMVolumeGroup CRD#71
nbalacha merged 1 commit intoopenshift:mainfrom
nbalacha:new-crd

Conversation

@nbalacha
Copy link
Copy Markdown
Contributor

Adds the new LVMVolumeGroup CRD type definition and related files.

Signed-off-by: N Balachandran nibalach@redhat.com

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

// EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN!
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these comments can be removed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
Copy link
Copy Markdown
Contributor

@sp98 sp98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

}

type NodeStatus struct {
// Node is the name of the node where the VG is to be created
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Node is the name of the node where the VG is to be created
// Node is the name of the node where the VG has been created

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be a node where the VG was supposed to be created but could not be.

//+kubebuilder:object:root=true
//+kubebuilder:subresource:status

// LVMVolumeGroup is the Schema for the lvmvolumegroups API
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// LVMVolumeGroup is the Schema for the lvmvolumegroups API
// LVMVolumeGroup is the schema for the lvmvolumegroups API

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was autogenerated by operator-sdk. The same comment exists in the other type definitions as well.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmolmo, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Adds the new LVMVolumeGroup CRD type definition and related files

Signed-off-by: N Balachandran <nibalach@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 13, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@nbalacha nbalacha merged commit b76aeb2 into openshift:main Jan 13, 2022
@nbalacha nbalacha deleted the new-crd branch January 18, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants