Skip to content

OCPEDGE-1245: feat(tests) add lvmd.yaml test#720

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
qJkee:OCPEDGE-1245
Sep 19, 2024
Merged

OCPEDGE-1245: feat(tests) add lvmd.yaml test#720
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
qJkee:OCPEDGE-1245

Conversation

@qJkee
Copy link
Copy Markdown
Contributor

@qJkee qJkee commented Sep 16, 2024

Add test case for overprovision ratio changes
to be reflected in lvmd config file

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 16, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 16, 2024

@qJkee: This pull request references OCPEDGE-1245 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Add test case for overprovision ratio changes
to be reflected in lvmd config file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@qJkee qJkee force-pushed the OCPEDGE-1245 branch 5 times, most recently from f78ac0b to 7678efa Compare September 17, 2024 17:52
Add test case for overprovision ratio changes
to be reflected in lvmd config file
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2024
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.58%. Comparing base (eb6dbdf) to head (bca210e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   69.94%   69.58%   -0.36%     
==========================================
  Files          49       49              
  Lines        3350     3350              
==========================================
- Hits         2343     2331      -12     
- Misses        831      843      +12     
  Partials      176      176              

see 5 files with indirect coverage changes

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Sep 18, 2024

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qJkee
Copy link
Copy Markdown
Contributor Author

qJkee commented Sep 19, 2024

/cc @suleymanakbas91

@suleymanakbas91
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e44108e into openshift:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants