Skip to content

NO-JIRA: Fix typo in lvmvolumegroupnodestatus during lvm must-gather collection#849

Merged
suleymanakbas91 merged 1 commit intoopenshift:mainfrom
yuokada126:patch-1
Feb 3, 2025
Merged

NO-JIRA: Fix typo in lvmvolumegroupnodestatus during lvm must-gather collection#849
suleymanakbas91 merged 1 commit intoopenshift:mainfrom
yuokada126:patch-1

Conversation

@yuokada126
Copy link
Copy Markdown
Contributor

Previously, due to a typo in the lvmvolumegroupnodestatus resource name within the must-gather script, only the 'get' output was collected, while the 'describe' output was missing. This fix corrects the resource name, ensuring that both 'get' and 'describe' outputs are properly gathered.

Previously, due to a typo in the lvmvolumegroupnodestatus resource name within the must-gather script, only the 'get' output was collected, while the 'describe' output was missing. This fix corrects the resource name, ensuring that both 'get' and 'describe' outputs are properly gathered.

Signed-off-by: Yuki Okada <yuokada@redhat.com>
@openshift-ci openshift-ci bot requested review from jerpeter1 and qJkee February 2, 2025 13:23
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.53%. Comparing base (8b31b1f) to head (807758f).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   69.64%   69.53%   -0.12%     
==========================================
  Files          50       50              
  Lines        3443     3443              
==========================================
- Hits         2398     2394       -4     
- Misses        862      864       +2     
- Partials      183      185       +2     

see 1 file with indirect coverage changes

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 2, 2025

@yuokada126: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Copy Markdown
Contributor

Thanks a lot for the catch, @yuokada126!

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91, yuokada126

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@suleymanakbas91 suleymanakbas91 changed the title Fix typo in lvmvolumegroupnodestatus during lvm must-gather collection NO-JIRA: Fix typo in lvmvolumegroupnodestatus during lvm must-gather collection Feb 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 3, 2025
@openshift-ci-robot
Copy link
Copy Markdown

@yuokada126: This pull request explicitly references no jira issue.

Details

In response to this:

Previously, due to a typo in the lvmvolumegroupnodestatus resource name within the must-gather script, only the 'get' output was collected, while the 'describe' output was missing. This fix corrects the resource name, ensuring that both 'get' and 'describe' outputs are properly gathered.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@suleymanakbas91 suleymanakbas91 merged commit 506025e into openshift:main Feb 3, 2025
@yuokada126 yuokada126 deleted the patch-1 branch February 14, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants