NO-JIRA: Fix typo in lvmvolumegroupnodestatus during lvm must-gather collection#849
Conversation
Previously, due to a typo in the lvmvolumegroupnodestatus resource name within the must-gather script, only the 'get' output was collected, while the 'describe' output was missing. This fix corrects the resource name, ensuring that both 'get' and 'describe' outputs are properly gathered. Signed-off-by: Yuki Okada <yuokada@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
- Coverage 69.64% 69.53% -0.12%
==========================================
Files 50 50
Lines 3443 3443
==========================================
- Hits 2398 2394 -4
- Misses 862 864 +2
- Partials 183 185 +2 |
|
@yuokada126: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thanks a lot for the catch, @yuokada126! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suleymanakbas91, yuokada126 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yuokada126: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Previously, due to a typo in the lvmvolumegroupnodestatus resource name within the must-gather script, only the 'get' output was collected, while the 'describe' output was missing. This fix corrects the resource name, ensuring that both 'get' and 'describe' outputs are properly gathered.