Skip to content

Router metrics change to use http1 cockroach db matcher #20873

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ramr:fix-bugz1623632
Sep 7, 2018
Merged

Router metrics change to use http1 cockroach db matcher #20873
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ramr:fix-bugz1623632

Conversation

@ramr
Copy link
Copy Markdown
Contributor

@ramr ramr commented Sep 6, 2018

Router metrics change to use http1 cockroach db matcher instead of Http1Fast
for backward compatibility.

fixes bugz 1623632 ( https://bugzilla.redhat.com/show_bug.cgi?id=1623632 )

/cc @openshift/sig-network-edge

@openshift-ci-robot openshift-ci-robot added sig/network-edge size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2018
Copy link
Copy Markdown

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2018
@ironcladlou
Copy link
Copy Markdown
Contributor

Could this be unit tested?

@ironcladlou
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, pravisankar, ramr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2018
@ramr
Copy link
Copy Markdown
Contributor Author

ramr commented Sep 6, 2018

/retest

@ramr
Copy link
Copy Markdown
Contributor Author

ramr commented Sep 6, 2018

@ironcladlou ack will add a unit test in a follow up PR. The metrics pieces have no unit tests currently.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ramr
Copy link
Copy Markdown
Contributor Author

ramr commented Sep 6, 2018

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f243068 into openshift:master Sep 7, 2018
@ironcladlou
Copy link
Copy Markdown
Contributor

/cherrypick release-3.11

@openshift-cherrypick-robot
Copy link
Copy Markdown

@ironcladlou: new pull request created: #21043

Details

In response to this:

/cherrypick release-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/network-edge size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants