CNV-83205: enable RebootPolicy feature gate in interop deploy-cnv#77801
CNV-83205: enable RebootPolicy feature gate in interop deploy-cnv#77801lukas-bednar wants to merge 2 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@lukas-bednar: This pull request references CNV-83205 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@lukas-bednar: This pull request references CNV-83205 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 51 minutes and 43 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a post-deployment configuration step to enable the KubeVirt Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lukas-bednar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@lukas-bednar: This pull request references CNV-83205 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Could we add that feature gate here?
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/step-registry/interop-tests/deploy-cnv/interop-tests-deploy-cnv-commands.sh (1)
79-79: Use the namespace variable here for consistency.At Line 79, hardcoding
openshift-cnvdiverges from the variable-based usage on Line 73.Small consistency tweak
-oc wait hyperconverged -n openshift-cnv kubevirt-hyperconverged --for=condition=Available --timeout=15m +oc wait hyperconverged -n "${CNV_INSTALL_NAMESPACE}" kubevirt-hyperconverged --for=condition=Available --timeout=15m🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/step-registry/interop-tests/deploy-cnv/interop-tests-deploy-cnv-commands.sh` at line 79, Replace the hardcoded namespace in the oc wait command by using the existing namespace variable referenced earlier in the script (the same variable used on Line 73) instead of "openshift-cnv"; update the oc wait hyperconverged -n openshift-cnv kubevirt-hyperconverged --for=condition=Available --timeout=15m invocation to use that variable (e.g., -n "$<namespace_variable>") so it stays consistent with other commands in the script.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/step-registry/interop-tests/deploy-cnv/interop-tests-deploy-cnv-commands.sh`:
- Line 79: Replace the single-line "oc wait hyperconverged -n openshift-cnv
kubevirt-hyperconverged --for=condition=Available --timeout=15m" with an
explicit reconciliation poll for the kubevirt-hyperconverged resource in
${CNV_INSTALL_NAMESPACE}: after you patch the RebootPolicy, loop (with a
timeout) calling "oc get hyperconverged -n ${CNV_INSTALL_NAMESPACE}
kubevirt-hyperconverged -o jsonpath=..." and wait until
.status.observedGeneration is >= .metadata.generation (ensuring the patch was
reconciled), then call the existing wait for condition=Available; also replace
the hardcoded namespace openshift-cnv with ${CNV_INSTALL_NAMESPACE} so both the
reconciliation check and the subsequent oc wait operate against the same
variable namespace.
---
Nitpick comments:
In
`@ci-operator/step-registry/interop-tests/deploy-cnv/interop-tests-deploy-cnv-commands.sh`:
- Line 79: Replace the hardcoded namespace in the oc wait command by using the
existing namespace variable referenced earlier in the script (the same variable
used on Line 73) instead of "openshift-cnv"; update the oc wait hyperconverged
-n openshift-cnv kubevirt-hyperconverged --for=condition=Available --timeout=15m
invocation to use that variable (e.g., -n "$<namespace_variable>") so it stays
consistent with other commands in the script.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8cfa210c-d0fd-4e69-a9df-690a6a2a4841
📒 Files selected for processing (1)
ci-operator/step-registry/interop-tests/deploy-cnv/interop-tests-deploy-cnv-commands.sh
ci-operator/step-registry/interop-tests/deploy-cnv/interop-tests-deploy-cnv-commands.sh
Outdated
Show resolved
Hide resolved
openshift-ci
bot
added
the
needs-rebase
interop-tests-cnv-tests-e2e-deploy fails when reboot policy specs run without the KubeVirt RebootPolicy feature gate. Mirror cnv-qe-automation: annotate HyperConverged with kubevirt.kubevirt.io/jsonpatch to append RebootPolicy to developerConfiguration.featureGates, then wait for Available. Made-with: Cursor
…patch - Use CNV_INSTALL_NAMESPACE and HCO_NAME for HyperConverged create, annotate, and oc wait. - After RebootPolicy jsonpatch, poll until status.observedGeneration >= metadata.generation so Available does not return before the annotation is reconciled. CNV-83205 Made-with: Cursor
lukas-bednar
force-pushed
the
cnv-83205-interop-reboot-policy-gate
branch
from
e89e953 to
5ae6c20
Compare
openshift-ci
bot
removed
the
needs-rebase
openshift-merge-bot
bot
added
the
rehearsals-ack
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
openshift-merge-bot
bot
removed
the
rehearsals-ack
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@lukas-bednar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
added
the
rehearsals-ack
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
2 participants
CNV-83205
Interop periodic
interop-tests-cnv-tests-e2e-deploywas failing with:RebootPolicy is specified but the RebootPolicy feature gate is not enabled.Change
After HyperConverged is first Available, annotate it with the same
kubevirt.kubevirt.io/jsonpatchused in cnv-qe-automation (appendRebootPolicyto KubeVirtdeveloperConfiguration.featureGates), then wait for Available again.File
ci-operator/step-registry/interop-tests/deploy-cnv/interop-tests-deploy-cnv-commands.shSummary by CodeRabbit
New Features
RebootPolicyfeature gate is now enabled during interop test deployments.Test Updates
Availablestate after deployment configuration changes, ensuring stability before proceeding with tests.