Open
Conversation
Member
Author
|
Update: polyfilling using https://github.com/guybedford/es-module-shims does not seem to work for Pale Moon, so including it to combat incompatibility is not an option |
Member
|
I'm okay with using import maps, its a HTML standard now and there are enough browser choices that support it. https://html.spec.whatwg.org/multipage/webappapis.html#import-maps https://github.com/WICG/import-maps?tab=readme-ov-file#readme |
Member
Yet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to generically solve the usage of JS modules. In the specific case of bootgrid, this is necessary for #9006. Specifically, we want to extend the ESM-aware library code of Tabulator, but cannot do so cleanly without import statements.
To use such modules, one can specify:
In the UIBootgrid case, the single
importindefault.voltwill expose bothUIBootgridand$(<element>).UIBootgrid()for all sub-templates.The ControllerBase and default volt template have been adjusted to allow for new inclusions as well.
I am aware of the discussion in #7777 and the associated risk with using
importmap, which is why I'm opening this as a PR.Note that this PR switches the Tabulator UMD build to an ESM one.