Skip to content

logic of BatcherSubmitter#37

Merged
GrapeBaBa merged 1 commit intooptimism-java:mainfrom
thinkAfCod:batcher
Aug 10, 2023
Merged

logic of BatcherSubmitter#37
GrapeBaBa merged 1 commit intooptimism-java:mainfrom
thinkAfCod:batcher

Conversation

@thinkAfCod
Copy link
Copy Markdown
Collaborator

@thinkAfCod thinkAfCod commented Aug 4, 2023

#36

GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/publisher/ChannelDataPublisher.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/publisher/ChannelDataPublisher.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
l2Client.ethGetBlockByNumber(DefaultBlockParameter.valueOf(number), true);
EthBlock.Block block;
try (var scope = new StructuredTaskScope.ShutdownOnFailure()) {
var blockFur = scope.fork(ethBlockRequest::send);
Copy link
Copy Markdown
Member

@GrapeBaBa GrapeBaBa Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blockFur这个缩写不对吧

GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/loader/BlockLoader.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/channel/ChannelManager.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/BatcherSubmitter.java
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/BatcherSubmitter.java Outdated
GrapeBaBa
GrapeBaBa reviewed Aug 8, 2023
View reviewed changes
Comment thread hildr-batcher/src/main/java/io/optimism/batcher/BatcherSubmitter.java Outdated
@thinkAfCod thinkAfCod force-pushed the batcher branch 8 times, most recently from 0a24d2f to 9077af1 Compare August 9, 2023 01:59
@GrapeBaBa GrapeBaBa merged commit 8776142 into optimism-java:main Aug 10, 2023
@thinkAfCod thinkAfCod mentioned this pull request Aug 11, 2023
Merged
@thinkAfCod thinkAfCod deleted the batcher branch August 16, 2023 08:50
@thinkAfCod thinkAfCod mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrapeBaBa GrapeBaBa GrapeBaBa left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkAfCod @GrapeBaBa