Skip to content

[FSSDK-8837] Implement API for sendOdpEvent in Agent#356

Merged
Mat001 merged 15 commits intomasterfrom
mpirnovar-odp
Mar 7, 2023
Merged

[FSSDK-8837] Implement API for sendOdpEvent in Agent#356
Mat001 merged 15 commits intomasterfrom
mpirnovar-odp

Conversation

@Mat001
Copy link
Copy Markdown
Contributor

@Mat001 Mat001 commented Feb 24, 2023 •
edited
Loading

Summary

  • Implement API for sendOdpEvent, update open api schema. Extend agent config to include odp.
  • extend config to accommodate ODP
  • update open API schema
  • unit tests

Issues

@Mat001 Mat001 self-assigned this Feb 24, 2023
@Mat001 Mat001 changed the title [FSSDK-8837] Add ODP wrapper [FSSDK-8837] Extend Agent with ODP wrapper functionality Feb 25, 2023
@Mat001 Mat001 changed the title [FSSDK-8837] Extend Agent with ODP wrapper functionality [FSSDK-8837] Extend Agent with ODP functionality Feb 25, 2023
@Mat001 Mat001 changed the title [FSSDK-8837] Extend Agent with ODP functionality [FSSDK-8837] Implement API for sendOdpEvent in Agent Mar 4, 2023
jaeopt
jaeopt requested changes Mar 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few changes suggested.

Comment thread api/openapi-spec/openapi.yaml
Comment thread pkg/handlers/decide.go Outdated
Comment thread pkg/handlers/send_odp_event.go Outdated
Comment thread pkg/handlers/send_odp_event.go Outdated
Comment thread pkg/handlers/send_odp_event.go Outdated
Comment thread pkg/handlers/send_odp_event.go
@Mat001 Mat001 requested a review from jaeopt March 7, 2023 19:16
yasirfolio3
yasirfolio3 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor change suggested, looks good overall.

Comment thread pkg/optimizely/optimizelytest/client.go Outdated
jaeopt
jaeopt approved these changes Mar 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pkg/handlers/send_odp_event.go
@Mat001 Mat001 merged commit e2f365c into master Mar 7, 2023
@Mat001 Mat001 deleted the mpirnovar-odp branch March 7, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

@andrewleap-optimizely andrewleap-optimizely Awaiting requested review from andrewleap-optimizely

+1 more reviewer

@yasirfolio3 yasirfolio3 yasirfolio3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Mat001 Mat001

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mat001 @yasirfolio3 @jaeopt