Conversation
Handle SDK keys with secure tokens in format 'sdkKey:apiKey' by extracting only the SDK key portion for notification processing.
Change comment from 'PSUBSCRIBE' to 'Subscribe/PSubscribe' to clarify support for both Redis subscription patterns in notification sync.
Add unit tests covering: - Standard SDK keys without secure tokens - Secure token format (sdkKey:apiKey) parsing - Edge cases: multiple colons, empty parts, empty headers - Integration test with notification event stream Ensures secure token parsing logic has proper test coverage.
Remove unused 'conf' variables that were causing linting errors in CI checks for the new secure token parsing unit tests.
Clean up trailing whitespace that was causing formatting issues in CI checks for golangci-lint.
Mat001
force-pushed
the
release/v4.2.1
branch
from
feb79f1 to
5193aff
Compare
![prisma-cloud-devsecops[bot]](https://avatars.githubusercontent.com/in/135857?s=60&v=4){kind=small}
| @@ -1,13 +1,13 @@ | |||
| ARG GO_VERSION | |||
| FROM golang:$GO_VERSION-alpine3.21 as builder | |||
| FROM golang:$GO_VERSION-alpine3.20 as builder | |||
There was a problem hiding this comment.
busybox 1.36.1 / Dockerfile.alpine.FROM
Total vulnerabilities: 4
| Critical: 0 | High: 0 | Medium: 4 | Low: 0 |
|---|
| Vulnerability ID | Severity | CVSS | Fixed in | Status |
|---|---|---|---|---|
| CVE-2023-42363 |  MEDIUM |
5.5 | - |
Open |
| CVE-2023-42364 | MEDIUM |
5.5 | - |
Open |
| CVE-2023-42365 | MEDIUM |
5.5 | - |
Open |
| CVE-2023-42366 | MEDIUM |
5.5 | - |
Open |
Mat001
force-pushed
the
release/v4.2.1
branch
from
5193aff to
b94a793
Compare
… channel The previous test was closing the event channel immediately, which caused the notification handler to hang in an infinite loop reading zero values. Fix by using a context timeout to properly terminate the test.
Mat001
force-pushed
the
release/v4.2.1
branch
from
c2513aa to
8fc0e5e
Compare
Mat001
force-pushed
the
release/v4.2.1
branch
from
4056d7e to
b1527dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdkKey:apiKeyIssues
https://jira.sso.episerver.net/browse/FSSDK-11793
https://jira.sso.episerver.net/browse/FSSDK-11833