Fix exception type for negative __length_hint__ return value#758
Open
jseop-lim wants to merge 1 commit intooracle:masterfrom
Open
Fix exception type for negative __length_hint__ return value#758jseop-lim wants to merge 1 commit intooracle:masterfrom
__length_hint__ return value#758jseop-lim wants to merge 1 commit intooracle:masterfrom
Conversation
Signed-off-by: Jeongseop Lim <jeongseop_lim@korea.ac.kr>
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #757
When
__length_hint__()returns a negative integer, GraalPy raisesTypeErrorinstead ofValueError. CPython'sPyObject_LengthHint(Objects/abstract.c:141-144) raisesValueErrorfor this case.AS-IS
TO-BE
(matching CPython)
Changes
ValueErrorinstead ofTypeErrorfor negative__length_hint__return value inIteratorNodes.GetLength.length, matching CPython'sPyObject_LengthHint. The adjacent non-integer branch continues to raiseTypeErroras before.