Fail earlier when float timestamp passed with OC-MTime

[PVince81]

Ref: owncloud/pyocclient#190

Basically do a Webdav PUT and set a float value for the OC-MTime header.

Expected result: eithter ownCloud discards the float part or fails earlier.

Actual result: mtime is passed through to the database and fails during INSERT, which is too late.

I didn't try it but maybe if you pass a string it will also fail at the DB level.

See linked ticket for an exception message.

[virajparimi]

@PVince81
So basically, all we need to do is check if stat_result.st_mtime is a float value and if it is then trim the decimal part?

[PVince81]

@Viraj96 yes, that is the fix for the pyocclient library directly.

The second part of the fix is to put in ownCloud core a validation that the mtime is an integer. If it's not an integer, throw a BadRequest exception.

[virajparimi]

@PVince81 So all we need to check is whether $request->server['HTTP_X_OC_MTIME'] is an integer or not using something like is_int function and if not then throw a BadRequest exception? What should be the message to the exception?

[PVince81]

@Viraj96 yes, on ownCloud core's PHP side. BadRequest sounds good.

[individual-it]

is this fixed by #28066 ?

[ownclouders]

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.

[phil-davis]

Should have been fixed by #28066 - leaving closed