Skip to content

feat: default github_token to github.token#624

Draft
MichaelDeBoey wants to merge 8 commits intopeaceiris:mainfrom
MichaelDeBoey:patch-1
Draft

feat: default github_token to github.token#624
MichaelDeBoey wants to merge 8 commits intopeaceiris:mainfrom
MichaelDeBoey:patch-1

Conversation

@MichaelDeBoey
Copy link
Copy Markdown

@MichaelDeBoey MichaelDeBoey commented Jun 18, 2021

Fixes #309

@peaceiris
Copy link
Copy Markdown
Owner

Thank you for the work. This pull-request fixes #309

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2021

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.73%. Comparing base (2c9f853) to head (4509111).
⚠️ Report is 320 commits behind head on main.

Files with missing lines Patch % Lines
src/set-tokens.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   61.73%   61.73%           
=======================================
  Files           4        4           
  Lines         277      277           
  Branches       49       49           
=======================================
  Hits          171      171           
  Misses        105      105           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MichaelDeBoey
Copy link
Copy Markdown
Author

@peaceiris I think this one can be merged?

@peaceiris
Copy link
Copy Markdown
Owner

I have added #309 to the v4 milestone. Since it takes a long time to publish, I will investigate this first from the viewpoint of backward compatibility, then try to merge this into the v3 line. 👍

@MichaelDeBoey
Copy link
Copy Markdown
Author

@peaceiris this PR is backwards compatible, as the action now defaults to github.token when it's not provided.
If people provide it themselves, it will still work.

@peaceiris
Copy link
Copy Markdown
Owner

peaceiris commented Sep 9, 2021

this PR is backwards compatible, as the action now defaults to github.token when it's not provided. If people provide it themselves, it will still work.

Not enough. We need to consider the source code. Perhaps, 631dd15 enables backward compatibility.

@peaceiris peaceiris marked this pull request as draft September 9, 2021 15:34
@privatenumber
Copy link
Copy Markdown

I understand this change is not backwards compatible because of the case where users are using personal_token instead of github_token (so this is empty).

AFAIK, using a PAT or GITHUB_TOKEN is interchangeable (just different permissions).

Would it be possible to eventually consolidate these two inputs into a token that defaults to github.token?

@peaceiris peaceiris added this to the v3.9.0 milestone Dec 21, 2021
@georgettica
Copy link
Copy Markdown

Could we promote this?
I saw some code and the GitHub token sws non required.
Would be glad to help here if I can (as it seems straightforward)

foursixnine added a commit to os-autoinst/os-autoinst-distri-opensuse that referenced this pull request Jul 21, 2022
Permission was wrong in the first place, waiting for peaceiris/actions-gh-pages#624 to be merged to update the version of the action.
ilmanzo pushed a commit to ilmanzo/os-autoinst-distri-opensuse that referenced this pull request Jul 25, 2022
Permission was wrong in the first place, waiting for peaceiris/actions-gh-pages#624 to be merged to update the version of the action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: default the github_token input to ${{ github.token }}

4 participants