Optocoupler CTR, SRAM reset restore, voltage-limited current source, macOS paste#241
Open
esaruoho wants to merge 2 commits intopfalstad:v3-devfrom
Open
Optocoupler CTR, SRAM reset restore, voltage-limited current source, macOS paste#241esaruoho wants to merge 2 commits intopfalstad:v3-devfrom
esaruoho wants to merge 2 commits intopfalstad:v3-devfrom
Conversation
This was referenced Mar 2, 2026
Closed
…urce, macOS paste fix - Configurable optocoupler CTR (pfalstad#150): Add CTR % parameter to edit dialog, scale CCCS transfer expression by CTR multiplier. Default 100%. - SRAM restore on reset (pfalstad#184): Add "Restore Contents on Reset" checkbox. Stores initial map snapshot, restores it on simulation reset. - Voltage-limited current source (pfalstad#149): Add compliance voltage mode. When enabled, current source becomes open circuit beyond max voltage. - macOS Electron paste fix (pfalstad#138): Replace Menu.setApplicationMenu(false) with proper Edit menu so Cmd+C/V/X/A work in text fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When loading SRAM contents from a binary file, the filename is now captured and displayed next to the Load button as "Loaded: filename.bin". This helps users with multiple SRAMs identify which file was loaded into each one, addressing feedback from @MatNieuw on issue pfalstad#184. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5d6f4bb to
c4d25b8
Compare
Author
|
@pfalstad any takes on this? |
Owner
|
I tried to do the limited current source thing once and got constant convergence failures. Looks like your version has the same issue. Try opening all the switches. Also I wouldn't have a separate checkbox for the voltage limiting. I would just use a default of 0 meaning unlimited. |
Owner
|
the sram thing is good |
Owner
|
The optocoupler thing looks good. I would maybe just rename "CTR (%)" to "CTR Scale" because it doesn't look like the CTR is exactly 100... At least in my test case it wasn't. |
Owner
|
the mac thing is good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Rebased onto
v3-dev(replaces #223 which targeted master).Fixes #150, #184, #149, #138.
Changes from master version
dumpXml()/undumpXml()in CurrentElm and SRAMElm to serialize new fieldsparseContentsString()helperTest plan
🤖 Generated with Claude Code